tests/unit/routes/public/partners-test.js (1)

7-10: Consider expanding test coverage beyond existence checks.

While this existence test is standard and acceptable for initial development, consider adding tests for route behavior, model hooks, or transitions in future iterations to ensure comprehensive coverage.

tests/unit/routes/public/board-test.js (1)

7-10: Consider expanding test coverage beyond existence checks.

As with the partners route test, consider adding tests for route-specific behavior in future iterations for more comprehensive coverage.

app/components/public/card.hbs (1)

1-8: Consider standardizing prop naming to camelCase.

The @imgurl prop uses lowercase, which is inconsistent with JavaScript/Ember conventions. Consider renaming to @imageUrl for better consistency across the codebase.

tests/integration/components/public/card-test.js (1)

9-22: Consider expanding test coverage.

While the current tests verify basic rendering, consider adding test cases for:

• The @horizontal prop (verify conditional class application)
• Image rendering with @imgurl
• All props rendered together to ensure they don't conflict

Example additions:

test('it applies horizontal class', async function (assert) {
  await render(hbs`<Public::Card @horizontal={{true}} />`);
  assert.dom('.circle-card').hasClass('horizontal');
  
  await render(hbs`<Public::Card @horizontal={{false}} />`);
  assert.dom('.circle-card').hasClass('vertical');
});

test('it renders image', async function (assert) {
  await render(hbs`<Public::Card @imgurl="/test.jpg" />`);
  assert.dom('.card-image').hasAttribute('src', '/test.jpg');
});

app/styles/components/public/card.scss (1)

55-59: Consider removing text-align: justify.

The text-align: justify property can create uneven word spacing and rivers of whitespace, which reduces readability, especially for shorter text blocks. Modern web typography generally favors left-aligned text for better readability.

Apply this diff:

     .card-text {
       margin-top: 1rem;
-      text-align: justify;
+      text-align: left;
       font-size: 1.5rem;
     }

app/routes/public/board.js (1)

1-3: Consider removing empty route class if no logic is needed.

Empty route classes can typically be omitted unless you plan to add model hooks, lifecycle methods, or other route-specific logic later. Ember will automatically generate the route if only the template exists.

app/styles/routes/public.scss (2)

29-29: Add space before opening brace for consistency.

The selector is missing a space before the opening brace, which is inconsistent with the rest of the codebase styling.

Apply this diff:

-  .red-container{
+  .red-container {

---

15-15: Consider responsive width constraint for mobile devices.

Setting .public-text to width: 80vw might cause horizontal scrolling or awkward layouts on mobile devices. Consider adding a max-width in pixels or using responsive breakpoints to adjust the width for smaller screens.

Example adjustment:

   .public-text {
     width: 80vw;
+    max-width: 800px;
     font-size: 1.5rem;
     hyphens: none;
   }

app/templates/public/identity.hbs (1)

17-31: Simplify boolean attribute syntax.

The @horizontal = true syntax can be simplified to @horizontal={{true}} for consistency with Ember's component argument conventions, though the current syntax is valid.

Example (not requiring a diff, just for consistency):

@horizontal={{true}}

app/components/header-nav.hbs (1)

40-48: Consider using consistent dropdown item pattern.

The new navigation links use LinkTo directly with class="dropdown-item btn btn-primary", while the static pages above use ddm.linkTo from the dropdown menu API. This inconsistency may cause styling differences or unexpected behavior.

Consider using the dropdown menu API for consistency:

<ddm.item>
  <ddm.linkTo @route='public.board' class="btn btn-primary">
    {{t 'mixin.menuItems.board'}}
  </ddm.linkTo>
</ddm.item>

Or if intentional, verify that the styling remains consistent across all dropdown items.

translations/en.yaml (1)

88-144: LGTM! Consider proofreading for consistency.

The extensive new translations for board and identity sections are well-structured and provide comprehensive content for the new public pages. Consider a final proofreading pass to ensure tone and style consistency across all sections.

translations/nl.yaml (2)

162-169: Complete the partners section translations.

The partners section has multiple LANG-TODO placeholders that need to be populated before this can be considered production-ready. Since this is a WIP PR, this is expected, but please ensure these are completed before merging.

Do you want me to help draft placeholder content for the partners section, or open a tracking issue for completing these translations?

---

98-121: Consider breaking long story text into multiple lines.

The board member stories (chair-story, secretary-story, treasurer-story, assessor1-story) are formatted as very long single lines. While YAML accepts this, breaking them into multiple lines using YAML's literal (|) or folded (>) block scalar style would improve maintainability and readability in the source file.

Example refactor for chair-story:

-      chair-story: Hoi, ik ben Stefan en mag mezelf dit jaar Praeses noemen. Ik ben derdejaars student in Enschede en heb een half jaar IDE gestudeerd en heb er na een studieswitch nu een jaar Creative Business opzitten. Binnen Alpha ben ik de eindverantwoordelijke voor wat er gebeurt binnen de vereniging. Daarnaast zit ik vergadering voor, let ik erop dat het beleid goed wordt uitgevoerd, geef ik speeches en begeleid ik commissies en de andere bestuurders met hun taken.
+      chair-story: >
+        Hoi, ik ben Stefan en mag mezelf dit jaar Praeses noemen. Ik ben derdejaars student in Enschede en heb een half jaar IDE gestudeerd
+        en heb er na een studieswitch nu een jaar Creative Business opzitten. Binnen Alpha ben ik de eindverantwoordelijke voor wat er gebeurt binnen
+        de vereniging. Daarnaast zit ik vergadering voor, let ik erop dat het beleid goed wordt uitgevoerd, geef ik speeches en begeleid ik commissies
+        en de andere bestuurders met hun taken.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

app/templates/public/identity.hbs (1)

17-17: Inconsistent attribute spacing.

The @horizontal = true attributes have spaces around the equals sign, while @imgurl and @text do not. For consistency, remove the spaces.

Apply this diff:

-          @horizontal = true
+          @horizontal=true

Apply the same change to lines 24 and 31.

Also applies to: 24-24, 31-31

translations/nl.yaml (2)

142-143: Use proper YAML block scalar syntax for multi-line strings.

The multi-line string starting at line 142 uses quoted syntax that spans lines, which can be fragile. Use YAML's folded block scalar (>) or literal block scalar (|) for better readability and reliability.

Apply this diff:

-        intro: "Deze grondslag uit zich in de drie kernaspecten van de vereniging: vriendschap, vorming en verantwoordelijkheid.
-          Rondom deze drie kernaspecten is de vereniging opgebouwd en alles wat we doen sluit hierop aan:"
+        intro: >
+          Deze grondslag uit zich in de drie kernaspecten van de vereniging: vriendschap, vorming en verantwoordelijkheid.
+          Rondom deze drie kernaspecten is de vereniging opgebouwd en alles wat we doen sluit hierop aan:

The > folded block scalar will automatically join lines with spaces and is the recommended YAML syntax for multi-line text blocks.

---

164-164: Replace LANG-TODO placeholders with actual Dutch content.

The partners section contains multiple LANG-TODO placeholders. Since this is a WIP PR, these should be completed before merging.

Please ensure the following translation keys are completed:

• template.public.partners.intro (line 164)
• template.public.partners.our-partners.partner-1 (line 167)
• template.public.partners.our-partners.partner-2 (line 168)
• template.public.partners.our-partners.partner-3 (line 169)

Do you need help drafting Dutch content for these sections, or would you like me to open an issue to track these missing translations?

Also applies to: 167-169

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

app/templates/public/identity.hbs (3)

14-18: Remove spaces around the = sign in the @horizontal argument.

Line 17 uses non-standard spacing (@horizontal = true) that is inconsistent with the rest of the component arguments and contradicts the fixes applied in about-alpha.hbs from previous reviews.

Apply this diff:

       <Public::Card
         @imgurl="/images/public/index/vriendschap.jpg"
         @text="{{t 'template.public.identity.three-vs.vriendschap'}}"
-        @horizontal = true
+        @horizontal=true
       />

---

21-25: Remove spaces around the = sign in the @horizontal argument.

Same spacing issue as the first card instance.

Apply this diff:

       <Public::Card
         @imgurl="/images/public/index/vorming.jpg"
         @text="{{t 'template.public.identity.three-vs.vorming'}}"
-        @horizontal = true
+        @horizontal=true
       />

---

28-32: Remove spaces around the = sign in the @horizontal argument.

Same spacing issue as the previous card instances.

Apply this diff:

       <Public::Card
         @imgurl="/images/public/index/verantwoordelijkheid.jpg"
         @text="{{t 'template.public.identity.three-vs.verantwoordelijkheid'}}"
-        @horizontal = true
+        @horizontal=true
       />

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro